[ 
https://issues.apache.org/jira/browse/HDFS-9721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiao Chen updated HDFS-9721:
----------------------------
    Attachment: HDFS-9721.05.patch

Thanks for the review Eddy!
Patch 5 addresses all comments above. {{MetadataMap}} is an interface class, so 
I put the static method in {{PBImageTextWriter}}.
Patch 5 also adds a header line to the delimited oiv output. It also adds the 
{{d}} or {{-}} at the beginning of the permission string, to be consistent with 
the legacy OIV and {{-ls -R}}

> Allow Delimited PB OIV tool to run upon fsimage that contains INodeReference
> ----------------------------------------------------------------------------
>
>                 Key: HDFS-9721
>                 URL: https://issues.apache.org/jira/browse/HDFS-9721
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>         Attachments: HDFS-9721.01.patch, HDFS-9721.02.patch, 
> HDFS-9721.03.patch, HDFS-9721.04.patch, HDFS-9721.05.patch
>
>
> HDFS-6673 added the feature of Delimited format OIV tool on protocol buffer 
> based fsimage.
> However, if the fsimage contains {{INodeReference}}, the tool fails because:
> {code}Preconditions.checkState(e.getRefChildrenCount() == 0);{code}
> This jira is to propose allow the tool to finish, so that user can get full 
> metadata.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to