[
https://issues.apache.org/jira/browse/HDFS-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129776#comment-15129776
]
Junping Du commented on HDFS-9456:
----------------------------------
Thanks for updating the patch, [~xiaobingo]! There is an issue with calculating
minNodeGroups:
{code}
+ int minNodeGroups = 2;
+ minNodeGroups = Math.min(minNodeGroups, numberOfReplicas);
{code}
We are expecting no replica get duplicated on the same NodeGroup (at least for
VM case). This is because NodeGroup means the same locality & failure group
which won't have any benefit with putting replicas more than 1. Thus, here
minNodeGroups should set to numberOfReplicas directly.
Other looks good.
CC [~szetszwo].
> BlockPlacementPolicyWithNodeGroup should override verifyBlockPlacement
> ----------------------------------------------------------------------
>
> Key: HDFS-9456
> URL: https://issues.apache.org/jira/browse/HDFS-9456
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Junping Du
> Assignee: Xiaobing Zhou
> Attachments: HDFS-9456.001.patch, HDFS-9456.002.patch
>
>
> Per discussions in HDFS-9314, we need to override verifyBlockPlacement() in
> BlockPlacementPolicyWithNodeGroup to reflect right block status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
