[
https://issues.apache.org/jira/browse/HDFS-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uma Maheswara Rao G updated HDFS-9713:
--------------------------------------
Attachment: HDFS-9713-00.patch
Here is a simple fix. This is straightforward change. I have verified it with
TestBalancer.java, which is having a testcase for pinned blocks. So, even after
return the current behavior should not change and it should work as is.
-------------------------------------------------------
T E S T S
-------------------------------------------------------
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.hadoop.hdfs.server.balancer.TestBalancer
Tests run: 31, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 322.695 sec -
in org.apache.hadoop.hdfs.server.balancer.TestBalancer
Results :
Tests run: 31, Failures: 0, Errors: 0, Skipped: 0
[~drankye] can you please review.
> DataXceiver#copyBlock should return if block is pinned
> ------------------------------------------------------
>
> Key: HDFS-9713
> URL: https://issues.apache.org/jira/browse/HDFS-9713
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Affects Versions: 2.7.2
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-9713-00.patch
>
>
> in DataXceiver#copyBlock
> {code}
> if (datanode.data.getPinning(block)) {
> String msg = "Not able to copy block " + block.getBlockId() + " " +
> "to " + peer.getRemoteAddressString() + " because it's pinned ";
> LOG.info(msg);
> sendResponse(ERROR, msg);
> }
> {code}
> I think we should return back instead of proceeding to send block.as we
> already sent ERROR here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
