[
https://issues.apache.org/jira/browse/HDFS-9700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131118#comment-15131118
]
Colin Patrick McCabe edited comment on HDFS-9700 at 2/3/16 9:02 PM:
--------------------------------------------------------------------
Thanks for updating this, [~ghelmling].
{code}
String DFS_CLIENT_SOCKET_TCPNODELAY_KEY =
"dfs.client.socket.tcpnodelay";
{code}
So, the changes you've made in this patch only affect
{{DatatTransferProtocol}}. The existing configuration key,
{{ipc.client.tcpnodelay}} will continue to cover the case where Hadoop RPC is
used, so it is not appropriate to claim that all client sockets are affected by
this. This configuration key should be called something like
{{data.transfer.protocol.client.tcpnodelay}}
was (Author: cmccabe):
Thanks for updating this, [~ghelmling].
{code}
String DFS_CLIENT_SOCKET_TCPNODELAY_KEY =
"dfs.client.socket.tcpnodelay";
{code}
So, the changes you've made in this patch only affect
{{DatatTransferProtocol}}. The existing configuration key,
{{ipc.client.tcpnodelay}} will continue to cover the case where Hadoop RPC is
used, so it is not appropriate to claim that all client sockets are affected by
this. This configuration key should be called something like
{{data.transfer.protocol.client.nodelay}}
> DFSClient and DFSOutputStream do not respect TCP_NODELAY config in two spots
> ----------------------------------------------------------------------------
>
> Key: HDFS-9700
> URL: https://issues.apache.org/jira/browse/HDFS-9700
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs-client
> Affects Versions: 2.7.1, 2.6.3
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Attachments: HDFS-9700-branch-2.7.002.patch, HDFS-9700-v1.patch,
> HDFS-9700-v2.patch, HDFS-9700.002.patch, HDFS-9700_branch-2.7-v2.patch,
> HDFS-9700_branch-2.7.patch
>
>
> In {{DFSClient.connectToDN()}} and
> {{DFSOutputStream.createSocketForPipeline()}}, we never call
> {{setTcpNoDelay()}} on the constructed socket before sending. In both cases,
> we should respect the value of ipc.client.tcpnodelay in the configuration.
> While this applies whether security is enabled or not, it seems to have a
> bigger impact on latency when security is enabled.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
