[
https://issues.apache.org/jira/browse/HDFS-9726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131147#comment-15131147
]
Jing Zhao commented on HDFS-9726:
---------------------------------
Thanks for the refactoring, Nicholas! The patch looks good to me. +1
One optional change can be: instead of using two boolean variable (ready2Send
and triggerIBR) to indicate what to do in {{notifyNamenodeBlock}}, maybe we can
create an enum to indicate the 3 types of action.
The test failures should be unrelated. I just re-triggered Jenkins.
> Refactor IBR code to a new class
> --------------------------------
>
> Key: HDFS-9726
> URL: https://issues.apache.org/jira/browse/HDFS-9726
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Priority: Minor
> Attachments: h9726_20160131.patch, h9726_20160201.patch,
> h9726_20160203.patch
>
>
> The IBR code currently is mainly in BPServiceActor. The JIRA is to refactor
> it to a new class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
