[
https://issues.apache.org/jira/browse/HDFS-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131219#comment-15131219
]
Hudson commented on HDFS-9748:
------------------------------
FAILURE: Integrated in Hadoop-trunk-Commit #9240 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/9240/])
HDFS-9748. Avoid duplication in pendingReplications when (jing9: rev
7badf156049b78cabf8537fff9846a0f9924a090)
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingReplication.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/PendingReplicationBlocks.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> When addExpectedReplicasToPending is called twice, pendingReplications should
> avoid duplication
> -----------------------------------------------------------------------------------------------
>
> Key: HDFS-9748
> URL: https://issues.apache.org/jira/browse/HDFS-9748
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.8.0
> Reporter: Walter Su
> Assignee: Walter Su
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HDFS-9748.01.patch
>
>
> 1. When completeFile() is called, addExpectedReplicasToPending() will be
> called (HDFS-8999).
> 2. When first replica is reported, addExpectedReplicasToPending() will be
> called the second time.
> {code}
> //BlockManager.addStoredBlock(..)
> if(storedBlock.getBlockUCState() == BlockUCState.COMMITTED &&
> hasMinStorage(storedBlock, numLiveReplicas)) {
> addExpectedReplicasToPending(storedBlock, bc);
> completeBlock(storedBlock, false);
> } else if (storedBlock.isComplete() && result == AddBlockResult.ADDED) {
> {code}
> But,
> {code}
> //PendingReplicationBlocks.java
> void incrementReplicas(DatanodeDescriptor... newTargets) {
> if (newTargets != null) {
> Collections.addAll(targets, newTargets);
> }
> }
> {code}
> targets is ArrayList, the above code simply add all {{newTargets}} to
> {{targets}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
