[
https://issues.apache.org/jira/browse/HDFS-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132822#comment-15132822
]
Kihwal Lee commented on HDFS-9730:
----------------------------------
No need to do manual testing anymore. HDFS-9739 fixed the bug of making
{{TestDatanodeStartupFixesLegacyStorageIDs}} pass.
The precommit says not this test case is fixed by your patch.
{noformat}
testUpgradeFrom22FixesStorageIDs 0.76 sec Fixed
testUpgradeFrom22via26FixesStorageIDs 3.8 sec Passed
testUpgradeFrom26PreservesStorageIDs 0.76 sec Passed
{noformat}
+1 The patch looks good.
> Storage ID update does not happen when there is a layout change
> ---------------------------------------------------------------
>
> Key: HDFS-9730
> URL: https://issues.apache.org/jira/browse/HDFS-9730
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Reporter: Kihwal Lee
> Assignee: Tsz Wo Nicholas Sze
> Attachments: h9730_20160202.patch, h9730_20160203.patch
>
>
> HDFS-9654 will cause test failures when we increment the datanode layout
> version next time.
> {noformat}
> TestDatanodeStartupFixesLegacyStorageIDs#testUpgradeFrom22via26FixesStorageIDs
> TestDatanodeStartupFixesLegacyStorageIDs#testUpgradeFrom22FixesStorageIDs
> {noformat}
> This is because createStorageID() is no longer called when it goes through
> the layout upgrade path.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
