[
https://issues.apache.org/jira/browse/HDFS-9788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15141860#comment-15141860
]
Uma Maheswara Rao G commented on HDFS-9788:
-------------------------------------------
{quote}
I don't think the YARN-3330 script would have caught it. We'd need to diff
proto files across release lines to detect such issues.
{quote}
Agreed. To catch this kind of issues, it has to run across versions. Not sure
if we have better ways to achieve that automatically.
> Incompatible tag renumbering in HeartbeatResponseProto
> ------------------------------------------------------
>
> Key: HDFS-9788
> URL: https://issues.apache.org/jira/browse/HDFS-9788
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: rolling upgrades
> Affects Versions: 2.8.0
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Priority: Blocker
> Attachments: HDFS-9788.001.patch
>
>
> The HDFS-9426 patches for branch-2.7 and branch-2 used different tag numbers
> for {{rollingUpgradeStatusV2}} in HeartbeatResponseProto:
> trunk/branch-2:
> {code}
> message HeartbeatResponseProto {
> repeated DatanodeCommandProto cmds = 1; // Returned commands can be null
> required NNHAStatusHeartbeatProto haStatus = 2;
> optional RollingUpgradeStatusProto rollingUpgradeStatus = 3;
> optional uint64 fullBlockReportLeaseId = 4 [ default = 0 ];
> optional RollingUpgradeStatusProto rollingUpgradeStatusV2 = 5;
> }
> {code}
> branch-2.7:
> {code}
> message HeartbeatResponseProto {
> repeated DatanodeCommandProto cmds = 1; // Returned commands can be null
> required NNHAStatusHeartbeatProto haStatus = 2;
> optional RollingUpgradeStatusProto rollingUpgradeStatus = 3;
> optional RollingUpgradeStatusProto rollingUpgradeStatusV2 = 4;
> }
> {code}
> This breaks rolling upgrade between 2.7 and a future 2.8. We need to renumber
> the tags to preserve wire compatibility.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
