[
https://issues.apache.org/jira/browse/HDFS-9797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144090#comment-15144090
]
Arun Suresh commented on HDFS-9797:
-----------------------------------
Makes Sense.. Thanks for raising this [~elgoiri] !!
The patch looks mostly good. Very minor nits :
# Remove the {{ret}} boolean variable in the {{isStandbyException}} method,
replace the inner most if with {{return (unwrapRemoteException instanceof
StandbyException)}} and do a {{return false;}} in the end.
# Maybe pull lines 124 - 132 into a new private method {{log(ex,
tProxyInfo.proxyInfo)}}
+1 pending the above
> RequestHedgingProxyProvider is too verbose with Standby exceptions
> ------------------------------------------------------------------
>
> Key: HDFS-9797
> URL: https://issues.apache.org/jira/browse/HDFS-9797
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs-client
> Affects Versions: 2.8.0
> Reporter: Inigo Goiri
> Assignee: Inigo Goiri
> Priority: Minor
> Attachments: HDFS-9797-v000.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> {{RequestHedgingProxyProvider}} tries to connect to all the Namenodes and
> reports the exception for all the standby exceptions for all the other
> namenodes. There is no point on reporting the standby exception if it's
> expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
