[
https://issues.apache.org/jira/browse/HDFS-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001835#comment-13001835
]
Boris Shkolnik commented on HDFS-1708:
--------------------------------------
+1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no new tests are needed
for this patch.
[exec] Also please list what manual steps were
performed to verify this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1
> remove datanode's datanodeId TODOs
> -----------------------------------
>
> Key: HDFS-1708
> URL: https://issues.apache.org/jira/browse/HDFS-1708
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
