[ 
https://issues.apache.org/jira/browse/HDFS-9787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149368#comment-15149368
 ] 

Inigo Goiri commented on HDFS-9787:
-----------------------------------

The latest version looks good to me.
I agree with [~vinayrpet] on opening a new JIRA to add a new RPC call for 
fixing this properly and just post this one as a bugfix for the current 
approach.
[~jesse_yates] thoughts?

> SNNs stop uploading FSImage to ANN once isPrimaryCheckPointer changed to 
> false.
> -------------------------------------------------------------------------------
>
>                 Key: HDFS-9787
>                 URL: https://issues.apache.org/jira/browse/HDFS-9787
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: ha
>    Affects Versions: 3.0.0
>            Reporter: Guocui Mi
>            Assignee: Guocui Mi
>         Attachments: HDFS-9787-v001.patch, HDFS-9787-v002.patch, 
> HDFS-9787-v003.patch, HDFS-9787-v004.patch
>
>
> SNNs stop uploading FSImage to ANN once isPrimaryCheckPointer become false. 
> Here is the logic to check if upload FSImage or not.
> In StandbyCheckpointer.java
> boolean sendRequest = isPrimaryCheckPointer || secsSinceLast >= 
> checkpointConf.getQuietPeriod();
>             doCheckpoint(sendRequest);
> The sendRequest is always false if isPrimaryCheckPointer is false giving 
> secsSinceLast (~checkpointPeriod) >= checkpointConf.getQuietPeriod() 
> (checkpointPeriod * this.quietMultiplier(default value 1.5)) always returns 
> false.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to