[ 
https://issues.apache.org/jira/browse/HDFS-9799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhe Zhang updated HDFS-9799:
----------------------------
    Attachment: HDFS-9799.05.patch

Thanks for the suggestion [~xyao]. An API level indication would be a nice. I 
explored 2 approaches:
# Add null elements in the returned collection
# Create a new data structure, something like {{GetTrashRootsResult}}, with a 
boolean flag indicating partial results

With either approach, it's pretty complex to reflect the structure of returned 
trash roots. This is because both {{FileSystem}} and {{DistributedFileSystem}} 
levels could return partial results (and in principle, any subclass of 
{{FileSystem}} could return partial results too). Given the complexity I 
suggest we just rely on WARN logging. Please see if you agree.

Updating the patch with minor cosmetic changes.

> Reimplement getCurrentTrashDir to remove incompatibility
> --------------------------------------------------------
>
>                 Key: HDFS-9799
>                 URL: https://issues.apache.org/jira/browse/HDFS-9799
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.8.0
>            Reporter: Zhe Zhang
>            Assignee: Zhe Zhang
>            Priority: Blocker
>         Attachments: HDFS-9799.00.patch, HDFS-9799.01.patch, 
> HDFS-9799.02.patch, HDFS-9799.03.patch, HDFS-9799.04.patch, HDFS-9799.05.patch
>
>
> HDFS-8831 changed the signature of {{TrashPolicy#getCurrentTrashDir}} by 
> adding an IOException. This breaks other applications using this public API. 
> This JIRA aims to reimplement the logic to safely handle the IOException 
> within HDFS.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to