[
https://issues.apache.org/jira/browse/HDFS-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002112#comment-13002112
]
Tsz Wo (Nicholas), SZE commented on HDFS-1684:
----------------------------------------------
Thanks Suresh for reviewing this.
{noformat}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or
modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
(version 1.3.9) warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
[exec]
[exec] -1 system test framework. The patch failed system test
framework compile.
{noformat}
Also checked the related unit tests.
> Federation: Balancer cannot start with with multiple namenodes.
> ---------------------------------------------------------------
>
> Key: HDFS-1684
> URL: https://issues.apache.org/jira/browse/HDFS-1684
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: balancer
> Affects Versions: Federation Branch
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 4342723.patch, h1684_20110302.patch
>
>
> The balancer creates the file when it starts; and delete the files when it
> finishes. The default FileSystem is used for all NameNodes. So only the
> first one will succeed creating the
> id file but the following will fail.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
