[
https://issues.apache.org/jira/browse/HDFS-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157590#comment-15157590
]
Arpit Agarwal commented on HDFS-1477:
-------------------------------------
Hi [~xiaobingo], a few comments below:
# Let's consider adding the ReconfigurationServlet change in a separate jira.
# Jenkins flagged a couple of findbugs warnings.
# Can you please fix the coding style to be consistent in NameNode.java? e.g.
{code}
namesystem.getBlockManager().getDatanodeManager()
.setHeartbeatInterval(DFS_HEARTBEAT_INTERVAL_DEFAULT);
namesystem
.getBlockManager()
.getDatanodeManager()
.setHeartbeatRecheckInterval(
DFS_NAMENODE_HEARTBEAT_RECHECK_INTERVAL_DEFAULT);
{code}
# The new test case should also assert that after calling
{{NameNode.reconfigureProperty()}}, {{NameNode.getConf().getProperty()}}
returns the new value in case of success.
# {[TestDFSAdmin#testNameNodeStartReconfiguration}} etc. need fixing.
> Support reconfiguring dfs.heartbeat.interval and
> dfs.namenode.heartbeat.recheck-interval without NN restart
> -----------------------------------------------------------------------------------------------------------
>
> Key: HDFS-1477
> URL: https://issues.apache.org/jira/browse/HDFS-1477
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: 2.7.0
> Reporter: Patrick Kling
> Assignee: Xiaobing Zhou
> Attachments: HDFS-1477-HDFS-9000.006.patch, HDFS-1477.005.patch,
> HDFS-1477.2.patch, HDFS-1477.3.patch, HDFS-1477.4.patch, HDFS-1477.patch
>
>
> Modify NameNode to implement the interface Reconfigurable proposed in
> HADOOP-7001. This would allow us to change certain configuration properties
> without restarting the name node.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
