[
https://issues.apache.org/jira/browse/HDFS-9838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15158115#comment-15158115
]
Jing Zhao commented on HDFS-9838:
---------------------------------
Thanks for the refactoring, Nicholas! The patch looks good to me. Some minor
comments:
# ExcessReplicaMap#contains and ExcessReplicaMap#remove should both take
BlockInfo instead of Block as input.
# Looks like some changes on imports are unnecessary.
> Refactor the excessReplicateMap to a class
> ------------------------------------------
>
> Key: HDFS-9838
> URL: https://issues.apache.org/jira/browse/HDFS-9838
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Attachments: h9838_20160219.patch, h9838_20160222.patch
>
>
> There are a lot of code duplication for accessing the excessReplicateMap in
> BlockManger. Let's refactor the related code to a class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
