[ 
https://issues.apache.org/jira/browse/HDFS-9804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15159285#comment-15159285
 ] 

Zhe Zhang commented on HDFS-9804:
---------------------------------

Thanks Xiao for the fix. The patch looks to me almost ready to go. A few minors:
# It's better to add some error handling in {{checkKerberosAndInit}}: what if 
{{DFS_BALANCER_KERBEROS_PRINCIPAL_KEY}} or the keytab file key is not set.
# Looks like {{getAddress}} can be folded into the {{checkKerberosAndInit}} 
method?
# Maybe {{checkKeytabAndInit}} is a better name?
# {{assertTrue(ugi.isLoginKeytabBased())}} should be 
{{UserGroupInformation.isLoginKeytabBased()}} since the method is static
# This can be a follow-on: ideally we can verify the behavior when used with 
the {{hdfs --daemon}} option.
# Another follow-on idea is to verify the relogin after TGT "max renew time" 
expires. It could be hard to control KDC TGT config though.

> Allow long-running Balancer in Kerberized Environments
> ------------------------------------------------------
>
>                 Key: HDFS-9804
>                 URL: https://issues.apache.org/jira/browse/HDFS-9804
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>              Labels: supportability
>         Attachments: HDFS-9804.01.patch, HDFS-9804.02.patch
>
>
> From the discussion of HDFS-9698, it might be nice to allow the balancer to 
> run as a daemon and login from a keytab.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to