[
https://issues.apache.org/jira/browse/HDFS-9847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15160335#comment-15160335
]
Lin Yiqun commented on HDFS-9847:
---------------------------------
Thanks everyone for comments and [~vinayrpet]'s patch. I have used in my patch.
The latest patch add the w(week) and y(year) in Configuration, and reuse the
{{Configuration::getTimeDuration}} API. And besides, as [[email protected]]
point out that there are many places will use milliseconds in testcases, I also
design a similar method {{getLongTimeMillis}}. This method can be reused for
parsing configuration which default time unit is {{MilliSecond}} in the future,
thanks review!
> HDFS configuration without time unit name should accept friendly time units
> ---------------------------------------------------------------------------
>
> Key: HDFS-9847
> URL: https://issues.apache.org/jira/browse/HDFS-9847
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 2.7.1
> Reporter: Lin Yiqun
> Assignee: Lin Yiqun
> Attachments: HDFS-9847.001.patch, HDFS-9847.002.patch,
> timeduration-w-y.patch
>
>
> In HDFS-9821, it talks about the issue of leting existing keys use friendly
> units e.g. 60s, 5m, 1d, 6w etc. But there are som configuration key names
> contain time unit name, like {{dfs.blockreport.intervalMsec}}, so we can make
> some other configurations which without time unit name to accept friendly
> time units. The time unit {{seconds}} is frequently used in hdfs. We can
> updating this configurations first.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
