[
https://issues.apache.org/jira/browse/HDFS-9710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15165669#comment-15165669
]
Jing Zhao commented on HDFS-9710:
---------------------------------
Thanks for working on this, Nicholas! The patch looks good to me. Some comments:
# In IncrementalBlockReportManager#sendIBRs, the "isDebugEnabled" check can be
skipped since we're using slf4j.Logger.
# We can add some new unit tests for the new feature/configuration.
> Change DN to send block receipt IBRs in batches
> -----------------------------------------------
>
> Key: HDFS-9710
> URL: https://issues.apache.org/jira/browse/HDFS-9710
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Attachments: h9710_20160201.patch, h9710_20160205.patch,
> h9710_20160216.patch, h9710_20160216b.patch, h9710_20160217.patch,
> h9710_20160219.patch
>
>
> When a DN has received a block, it immediately sends a block receipt IBR RPC
> to NN for reporting the block. Even if a DN has received multiple blocks at
> the same time, it still sends multiple RPCs. It does not scale well since NN
> has to process a huge number of RPCs when many DNs receiving many blocks at
> the same time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
