[ 
https://issues.apache.org/jira/browse/HDFS-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002322#comment-13002322
 ] 

Jitendra Nath Pandey commented on HDFS-1721:
--------------------------------------------

-1 overall.  

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 system test framework.  The patch failed system test framework compile.

system test framework failure is unrelated.

> Hdfs Federation: Configuration for principal names should not be namenode 
> specific.
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-1721
>                 URL: https://issues.apache.org/jira/browse/HDFS-1721
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>    Affects Versions: Federation Branch
>            Reporter: Jitendra Nath Pandey
>            Assignee: Jitendra Nath Pandey
>             Fix For: Federation Branch
>
>         Attachments: HDFS-1721.1.patch, HDFS-1721.2.patch
>
>
> The principal names in the configuration for namenode, secondary namenode, 
> backup namenode, need not be namenode specific, i.e. they need not be 
> configured with keys suffixed with nameserviceId.
> This is because if principals were namenode specific, we would need a 
> mechanism to figure out nameserviceId (to get the namenode specific 
> principal) from fqdn of the files at the client.
>  A simpler approach is to use _HOST pattern in the principal names. Hadoop 
> RPC supports replacing the _HOST in the principal with the hostname of the 
> service. Using this approach we need only one principal configuration for all 
> namenodes and similarly one for all secondary namenodes or backup namenodes. 

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to