[
https://issues.apache.org/jira/browse/HDFS-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002504#comment-13002504
]
Suresh Srinivas commented on HDFS-1718:
---------------------------------------
test-patch results:
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 12 new or
modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
(version 1.3.8) warnings.
[exec]
[exec] -1 release audit. The applied patch generated 100 release
audit warnings (more than the trunk's current 98 warnings).
[exec]
[exec] -1 system test framework. The patch failed system test
framework compile.
The -1 in release audit and system test framework is not related to this patch.
It is not expected after merging trunk to federation branch.
> HDFS Federation: MiniDFSCluster#waitActive() bug causes some tests to fail
> ---------------------------------------------------------------------------
>
> Key: HDFS-1718
> URL: https://issues.apache.org/jira/browse/HDFS-1718
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Affects Versions: Federation Branch
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: Federation Branch
>
> Attachments: HDFS-1718.patch
>
>
> MiniDFSCluster#shouldWait() method waits for all the datanodes to come up and
> register with the namenode.
> Due to threading issues some of the tests fail for two reasons:
> # Datanode#isDatanodeUp() fails even if all the BPOfferService threads have
> exited. This is due to Thread.isAlive()
> returning true, even though the thread has exited. Adding a check to
> BPOfferService#shouldService run as an addition,
> fixes this issues.
> # shouldWait(), where isBPServiceAlive() is called, does not work when a
> BPOfferService thread fails before the
> datanode has discovered the BPID, from handshake with namenode. This can be
> fixed by checking the thread state using
> InetSocketAddress to determine the BPOfferService, instead of BPID.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
