[
https://issues.apache.org/jira/browse/HDFS-9719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15171568#comment-15171568
]
Rakesh R commented on HDFS-9719:
--------------------------------
Thanks [~drankye] for the good work. Overall the changes looks pretty good.
I've few comments on the patch, please take a look at it:
# Please fix the checkstyle warnings that are needed.
# Add InterfaceAudience annotation to the new classes.
# Also, it would be good to use proper method level access specifiers.
Following are few such cases, perhaps you can check the same in your patch and
modify based on the need.
{code}
StripedWriters#createWriter() -> this can be made private as only used inside
this class.
StripedWriters#getRealTargets() -> this can be made private as only used inside
this class.
StripedReaders#doReadMinimum() -> this can be made private as only used inside
this class.
{code}
> Refactoring ErasureCodingWorker into smaller reusable constructs
> ----------------------------------------------------------------
>
> Key: HDFS-9719
> URL: https://issues.apache.org/jira/browse/HDFS-9719
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Attachments: HDFS-9719-v1.patch, HDFS-9719-v2.patch,
> HDFS-9719-v3.patch
>
>
> This would suggest and refactor {{ErasureCodingWorker}} into smaller
> constructs to be reused in other places like block group checksum computing
> in datanode side. As discussed in HDFS-8430 and implemented in HDFS-9694
> patch, checksum computing for striped block groups would be distributed to
> datanode in the group, where data block data should be able to be
> reconstructed when missed/corrupted to recompute the block checksum. The most
> needed codes are in the current ErasureCodingWorker and could be reused in
> order to avoid duplication. Fortunately, we have very good and complete
> tests, which would make the refactoring much easier. The refactoring will
> also help a lot for subsequent tasks in phase II for non-striping erasure
> coded files and blocks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
