[
https://issues.apache.org/jira/browse/HDFS-8356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15173253#comment-15173253
]
Akira AJISAKA edited comment on HDFS-8356 at 3/1/16 6:39 AM:
-------------------------------------------------------------
I reviewed the part before "dfs.client.failover.proxy.provider", and some
comments from me.
* The patch needs to be rebased.
* Why "name" and "value" is after "description" in the following code?
{code}
<property>
<description>
Maximum number of bytes that can be moved by the balancer in a single
thread.
</description>
<name>dfs.balancer.max-size-to-move</name>
<value>10737418240</value>
</property>
{code}
"dfs.client.retry.interval-ms.get-last-block-length" should be fixed as well.
* Would you comment that the class specified by
"dfs.block.placement.ec.classname" is for striped files and
"dfs.block.replicator.classname" is not for striped files?
was (Author: ajisakaa):
I reviewed the part before "dfs.client.failover.proxy.provider", and some
comments from me.
* The patch needs to be rebased.
* Why "name" and "value" is after "description" in the following code?
{code}
<property>
<description>
Maximum number of bytes that can be moved by the balancer in a single
thread.
</description>
<name>dfs.balancer.max-size-to-move</name>
<value>10737418240</value>
</property>
{code}
* Would you comment that the class specified by
"dfs.block.placement.ec.classname" is for striped files and
"dfs.block.replicator.classname" is not for striped files?
> Document missing properties in hdfs-default.xml
> -----------------------------------------------
>
> Key: HDFS-8356
> URL: https://issues.apache.org/jira/browse/HDFS-8356
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: documentation
> Affects Versions: 2.7.0
> Reporter: Ray Chiang
> Assignee: Ray Chiang
> Labels: supportability, test
> Attachments: HDFS-8356.001.patch, HDFS-8356.002.patch,
> HDFS-8356.003.patch, HDFS-8356.004.patch, HDFS-8356.005.patch
>
>
> The following properties are currently not defined in hdfs-default.xml. These
> properties should either be
> A) documented in hdfs-default.xml OR
> B) listed as an exception (with comments, e.g. for internal use) in the
> TestHdfsConfigFields unit test
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
