[ 
https://issues.apache.org/jira/browse/HDFS-9882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174597#comment-15174597
 ] 

Inigo Goiri commented on HDFS-9882:
-----------------------------------

I think the second approach makes more sense as other people may have already 
built some dependencies on the semantic of the current {{heartbeats}}.
The current approach in {{DatanodeMetrics}} has:
{code}
@Metric MutableRate heartbeats;
{code}

I would add:
{code}
@Metric MutableRate heartbeatsTotal;
{code}

> Change the meaning of heartbeat latency in Datanode metrics
> -----------------------------------------------------------
>
>                 Key: HDFS-9882
>                 URL: https://issues.apache.org/jira/browse/HDFS-9882
>             Project: Hadoop HDFS
>          Issue Type: Task
>          Components: datanode
>            Reporter: Hua Liu
>            Assignee: Hua Liu
>            Priority: Minor
>
> Heartbeat latency only reflects the time spent on generating reports and 
> sending reports to NN. When heartbeats are delayed due to processing 
> commands, this latency does not help investigation. I would like to propose 
> either (1) changing the heartbeat latency to reflect the total time spent on 
> sending reports and processing commands or (2) adding another metric counter 
> to show the total time. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to