[ 
https://issues.apache.org/jira/browse/HDFS-9882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180384#comment-15180384
 ] 

Arpit Agarwal commented on HDFS-9882:
-------------------------------------

Disk operations can be slow on any platform if the disk is loaded or bad. So I 
think it is a good idea to move those operations out of the heartbeat 
processing path which is perf-sensitive. Would you consider filing a separate 
Jira to fix the {{checkBlock}} issue described by [~hualiu]?

Meanwhile we can also add this new metric. Can you rename it to something like 
{{HeartbeatTotalTime}} and describe it in Metrics.md? 

> Add heartbeatsTotal in Datanode metrics
> ---------------------------------------
>
>                 Key: HDFS-9882
>                 URL: https://issues.apache.org/jira/browse/HDFS-9882
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: datanode
>    Affects Versions: 2.7.2
>            Reporter: Hua Liu
>            Assignee: Hua Liu
>            Priority: Minor
>         Attachments: 
> 0001-HDFS-9882.Add-heartbeatsTotal-in-Datanode-metrics.patch, 
> 0002-HDFS-9882.Add-heartbeatsTotal-in-Datanode-metrics.patch
>
>
> Heartbeat latency only reflects the time spent on generating reports and 
> sending reports to NN. When heartbeats are delayed due to processing 
> commands, this latency does not help investigation. I would like to propose 
> to add another metric counter to show the total time. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to