[ 
https://issues.apache.org/jira/browse/HDFS-9873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180429#comment-15180429
 ] 

Chris Nauroth commented on HDFS-9873:
-------------------------------------

Hi [~anu].  Nice work!

Do you think {{XceiverServer#start}} can be simplified so that it doesn't need 
to submit a background thread to bootstrap Netty?  With this background thread, 
the server startup happens asynchronous with respect to callers of {{start}}.  
That might cause some tricky non-deterministic behavior, such as for tests that 
want a guarantee the server is fully up and running before sending test 
requests.  Let me know your thoughts.

Would you please check the indentation in {{TestContainerServer}}?

Thank you.

> Ozone: Add container transport server
> -------------------------------------
>
>                 Key: HDFS-9873
>                 URL: https://issues.apache.org/jira/browse/HDFS-9873
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>             Fix For: HDFS-7240
>
>         Attachments: HDFS-9873-HDFS-7240.001.patch, 
> HDFS-9873-HDFS-7240.002.patch
>
>
> Add server part of the container transport



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to