[
https://issues.apache.org/jira/browse/HDFS-9556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185516#comment-15185516
]
James Clampffer commented on HDFS-9556:
---------------------------------------
It looks like you could get rid of the following in URI::encode
{code}
bool hasCharactersToEncode = false;
for (auto c : decoded)
{
if (isalnum(c) || (strchr(kReserved, c) == NULL))
{
continue;
}
else
{
hasCharactersToEncode = true;
break;
}
}
{code}
because the next loop still has to do the check for each character when
encoding.
Otherwise the patch looks good to me, +1 if you fix that or point out what I'm
missing that makes it required.
> libhdfs++: pull Options from default configs by default
> -------------------------------------------------------
>
> Key: HDFS-9556
> URL: https://issues.apache.org/jira/browse/HDFS-9556
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Bob Hansen
> Assignee: Bob Hansen
> Attachments: HDFS-9556.HDFS-8707.000.patch,
> HDFS-9556.HDFS-8707.002.patch
>
>
> Include method to connect to defaultFS from configuration
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
