[
https://issues.apache.org/jira/browse/HDFS-9944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15191513#comment-15191513
]
Chris Nauroth commented on HDFS-9944:
-------------------------------------
Hi [~anu]. This looks good. Just a few minor comments:
# There is a typo in the method name {{ContainerUtils#unspportedRequest}}.
# There is a typo in package-info.java: "This pacakage is contains Ozone
container implementation."
# The implementation of {{TestContainerManager}} does exactly what a Mockito
mock would do. Do you want to consider removing this class? Then, you could
replace {{new TestContainerManager()}} with {{mock(ContainerManager.class)}}.
Unless you're planning to put more logic into {{TestContainerManager}} in
future patches, using Mockito would reduce the amount of code.
> Ozone : Add container dispatcher
> --------------------------------
>
> Key: HDFS-9944
> URL: https://issues.apache.org/jira/browse/HDFS-9944
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Fix For: HDFS-7240
>
> Attachments: HDFS-9944-HDFS-7240.001.patch
>
>
> This patch takes a request packet from the network layer and delivers it to
> the container manager. ie. OzoneContainerManager.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
