[ 
https://issues.apache.org/jira/browse/HDFS-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202010#comment-15202010
 ] 

Chris Nauroth commented on HDFS-10179:
--------------------------------------

Hi [~anu].  I like the use of the MDC to provide more context about the 
operation executing that emitted the log message.

Can you please make all of the {{Logger}} instances {{private}}?  That's 
something we should generally do unless we have a compelling reason for one 
class to log through another tightly coupled class's logger.  (e.g. 
{{BPServiceActor}} uses {{DataNode#LOG}}.)

> Ozone: Adding logging support
> -----------------------------
>
>                 Key: HDFS-10179
>                 URL: https://issues.apache.org/jira/browse/HDFS-10179
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>         Attachments: HDFS-10179-HDFS-7240.001.patch
>
>
> Adds logging support to ozone.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to