[
https://issues.apache.org/jira/browse/HDFS-9960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200282#comment-15200282
]
Chris Nauroth commented on HDFS-9960:
-------------------------------------
Hi [~anu]. This looks good overall. Here are a few comments.
# {{OzoneMetadataManager#inProgressObjects}} is a {{HashMap}}, which is not a
thread-safe data structure. If multiple concurrent {{createKey}} calls are
executing, then there is a risk that it would corrupt the state of the internal
hash table. Perhaps a {{ConcurrentHashMap}} would do well here?
# In the {{OzoneMetadataManager}} constructor, there are two calls to
{{file.mkdirs()}}. Are these redundant? Can the first call be removed? That
would fix the last remaining Findbugs warning too.
Test failures are unrelated.
> OzoneHandler : Add localstorage support for keys
> ------------------------------------------------
>
> Key: HDFS-9960
> URL: https://issues.apache.org/jira/browse/HDFS-9960
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Fix For: HDFS-7240
>
> Attachments: HDFS-9960-HDFS-7240.001.patch,
> HDFS-9960-HDFS-7240.002.patch
>
>
> Adds local storage handler support for keys. This allows all REST api's to be
> exercised via MiniDFScluster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
