[
https://issues.apache.org/jira/browse/HDFS-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005388#comment-13005388
]
Jitendra Nath Pandey commented on HDFS-1746:
--------------------------------------------
-1 overall.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 system test framework. The patch passed system test framework compile.
This patch fixes an existing test failure, therefore no new tests added.
> Hdfs Federation: TestFileAppend3 fails intermittently.
> ------------------------------------------------------
>
> Key: HDFS-1746
> URL: https://issues.apache.org/jira/browse/HDFS-1746
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: Federation Branch
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Fix For: Federation Branch
>
> Attachments: HDFS-1746.1.patch
>
>
> TestFileAppend3 fails intermittently in the branch. The issue is that
> FSDataset#recoverCheck calls getReplicaInfo which also matches the generation
> stamp during pipeline recovery. The fix is to make sure generation stamp is
> not checked while replica lookup in this case as it is done in the trunk
> code. The generation stamp check is done later in recoverCheck method.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
