[ https://issues.apache.org/jira/browse/HDFS-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15205233#comment-15205233 ]
Colin Patrick McCabe commented on HDFS-10189: --------------------------------------------- +1 pending jenkins. Thanks. [~jpallas] > PacketResponder toString is built incorrectly > --------------------------------------------- > > Key: HDFS-10189 > URL: https://issues.apache.org/jira/browse/HDFS-10189 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode > Affects Versions: 2.7.1 > Reporter: Joe Pallas > Assignee: Joe Pallas > Priority: Minor > Attachments: HDFS-10189.patch > > > The constructor for {{BlockReceiver.PacketResponder}} says > {code} > final StringBuilder b = new StringBuilder(getClass().getSimpleName()) > .append(": ").append(block).append(", type=").append(type); > if (type != PacketResponderType.HAS_DOWNSTREAM_IN_PIPELINE) { > b.append(", downstreams=").append(downstreams.length) > .append(":").append(Arrays.asList(downstreams)); > } > {code} > So it includes the list of downstreams only when it has no downstreams. The > {{if}} test should be for equality. -- This message was sent by Atlassian JIRA (v6.3.4#6332)