[ 
https://issues.apache.org/jira/browse/HDFS-9959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15205585#comment-15205585
 ] 

Tsz Wo Nicholas Sze commented on HDFS-9959:
-------------------------------------------

For the new patch, please call init() in heartbeatCheck() but not add(..).  
Otherwise, blocks will be added for other cases such as when a block is deleted 
from the last datanode.

> ... Which solution is better: ...

Let's add only first thousand blocks, i.e. check missing.size() before adding 
the block.  We probably should print the log message in multiple lines, say 10 
blocks per line.

Thanks for the update.

> add log when block removed from last live datanode
> --------------------------------------------------
>
>                 Key: HDFS-9959
>                 URL: https://issues.apache.org/jira/browse/HDFS-9959
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: yunjiong zhao
>            Assignee: yunjiong zhao
>            Priority: Minor
>         Attachments: HDFS-9959.1.patch, HDFS-9959.2.patch, HDFS-9959.patch
>
>
> Add logs like "BLOCK* No live nodes contain block blk_1073741825_1001, last 
> datanode contain it is node: 127.0.0.1:65341" in BlockStateChange should help 
> to identify which datanode should be fixed first to recover missing blocks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to