[
https://issues.apache.org/jira/browse/HDFS-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005476#comment-13005476
]
Hadoop QA commented on HDFS-1748:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12473349/h1748_20110310.patch
against trunk revision 1080380.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.TestFileConcurrentReader
-1 contrib tests. The patch failed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/248//testReport/
Findbugs warnings:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/248//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/248//console
This message is automatically generated.
> Balancer utilization classification is incomplete
> -------------------------------------------------
>
> Key: HDFS-1748
> URL: https://issues.apache.org/jira/browse/HDFS-1748
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h1748_20110310.patch
>
>
> {code}
> //Balancer.java
> /* Return true if the given datanode is overUtilized */
> private boolean isOverUtilized(BalancerDatanode datanode) {
> return datanode.utilization > (avgUtilization+threshold);
> }
>
> /* Return true if the given datanode is above average utilized
> * but not overUtilized */
> private boolean isAboveAvgUtilized(BalancerDatanode datanode) {
> return (datanode.utilization <= (avgUtilization+threshold))
> && (datanode.utilization > avgUtilization);
> }
>
> /* Return true if the given datanode is underUtilized */
> private boolean isUnderUtilized(BalancerDatanode datanode) {
> return datanode.utilization < (avgUtilization-threshold);
> }
> /* Return true if the given datanode is below average utilized
> * but not underUtilized */
> private boolean isBelowAvgUtilized(BalancerDatanode datanode) {
> return (datanode.utilization >= (avgUtilization-threshold))
> && (datanode.utilization < avgUtilization);
> }
> {code}
> Where is {{datanode.utilization == avgUtilization}}?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
