[ 
https://issues.apache.org/jira/browse/HDFS-9732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212622#comment-15212622
 ] 

Allen Wittenauer commented on HDFS-9732:
----------------------------------------

To quote 
http://hadoop.apache.org/docs/r2.7.2/hadoop-project-dist/hadoop-common/Compatibility.html#Command_Line_Interface_CLI

{code}
The Hadoop command line programs may be use either directly via the system 
shell or via shell scripts. Changing the path of a command, removing or 
renaming command line options, the order of arguments, or the command return 
code and output break compatibility and may adversely affect users.
{code}

which means:

{code}
When backward compatibility is not needed, use toString(), which provides
 more info and is supposed to evolve, see HDFS-9732.
{code}

the toString method can pretty much never be called outside of logfiles.  It's 
also very likely be to called incorrectly.  I'd much rather see the frozen 
version be the normal toString and the 'flexible' one be something else.


> Remove DelegationTokenIdentifier.toString() —for better logging output
> ----------------------------------------------------------------------
>
>                 Key: HDFS-9732
>                 URL: https://issues.apache.org/jira/browse/HDFS-9732
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.7.2
>            Reporter: Steve Loughran
>            Assignee: Yongjun Zhang
>         Attachments: HADOOP-12752-001.patch, HDFS-9732.001.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> HDFS {{DelegationTokenIdentifier.toString()}} adds some diagnostics info, 
> owner, sequence number. But its superclass,  
> {{AbstractDelegationTokenIdentifier}} contains a lot more information, 
> including token issue and expiry times.
> Because  {{DelegationTokenIdentifier.toString()}} doesn't include this data,
> information that is potentially useful for kerberos diagnostics is lost.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to