[ 
https://issues.apache.org/jira/browse/HDFS-9952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213915#comment-15213915
 ] 

Walter Su commented on HDFS-9952:
---------------------------------

Thanks [~vinayrpet] for updating. Just one minor suggestion:
We should take care of {{readUnlock()}} being called even if currentThread 
doesn't have it actually. Just like {{writeUnlock()}} did. Better safe than 
sorry.
Otherwise, The patch looks pretty good to me. +1 once addressed. It would be 
great if [~daryn] can also take a look.

> Expose FSNamesystem lock wait time as metrics
> ---------------------------------------------
>
>                 Key: HDFS-9952
>                 URL: https://issues.apache.org/jira/browse/HDFS-9952
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>         Attachments: HDFS-9952-01.patch, HDFS-9952-02.patch, 
> HDFS-9952-03.patch
>
>
> Expose FSNameSystem's readlock() and writeLock() wait time as metrics.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to