[ 
https://issues.apache.org/jira/browse/HDFS-9869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15216891#comment-15216891
 ] 

Zhe Zhang commented on HDFS-9869:
---------------------------------

Thanks for the work Rakesh. A few minor issues:
# Some getter names are unchanged and are inconsistent with new variable names: 
{{getPendingReplicationBlocksCount}}, {{getExcessBlocksCount}}.
# How are we going to handle config keys like 
{{DFS_NAMENODE_REPLICATION_PENDING_TIMEOUT_SEC_KEY}}? One option is to leave 
them as-is and add some comments to explain. We can also deprecate them and 
create new ones with more accurate names. Pinging [~andrew.wang] for insights.

> Erasure Coding: Rename replication-based names in BlockManager to more 
> generic [part-2]
> ---------------------------------------------------------------------------------------
>
>                 Key: HDFS-9869
>                 URL: https://issues.apache.org/jira/browse/HDFS-9869
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: erasure-coding
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>         Attachments: HDFS-9869-001.patch
>
>
> The idea of this jira is to rename the following entities in BlockManager as,
> - {{PendingReplicationBlocks}} to {{PendingReconstructionBlocks}}
> - {{excessReplicateMap}} to {{extraRedundancyMap}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to