[
https://issues.apache.org/jira/browse/HDFS-8210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HDFS-8210:
--------------------------------
Attachment: HDFS-8210-HDFS-7240.007.patch
[~anu], thank you for the code review. I am attaching patch v007:
# That's a good idea on adding the matched prefix of the key on the located
container response. I have done this.
# Addressed Checkstyle warnings. There is going to be one warning remaining
which is unaddressable, due to the heartbeat method having a large number of
parameters. This is inherited from an existing HDFS interface, so it's not
something that can be changed right now.
That's a good question on deleting a key and its effects on the view of the
keyspace as maintained by SCM. I would like to defer this to a later patch.
The semantic of {{hasReadLock}} are duplicated from the {{FSNamesystem}}
implementation. I can see how this could be open to multiple interpretations,
because the {{RwLock}} interface does not state the semantics precisely. I
left this as is for now.
The license warnings are unrelated.
> Ozone: Implement storage container manager
> -------------------------------------------
>
> Key: HDFS-8210
> URL: https://issues.apache.org/jira/browse/HDFS-8210
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Jitendra Nath Pandey
> Assignee: Chris Nauroth
> Attachments: HDFS-8210-HDFS-7240.006.patch,
> HDFS-8210-HDFS-7240.007.patch, HDFS-8210-HDFS-7240.1.patch,
> HDFS-8210-HDFS-7240.2.patch, HDFS-8210-HDFS-7240.3.patch,
> HDFS-8210-HDFS-7240.4.patch, HDFS-8210-HDFS-7240.5.patch
>
>
> The storage container manager collects datanode heartbeats, manages
> replication and exposes API to lookup containers. This jira implements
> storage container manager by re-using the block manager implementation in
> namenode. This jira provides initial implementation that works with
> datanodes. The additional protocols will be added in subsequent jiras.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
