[
https://issues.apache.org/jira/browse/HDFS-10192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226764#comment-15226764
]
Jing Zhao commented on HDFS-10192:
----------------------------------
Thanks for the fix, [~brahmareddy]. The patch looks good to me. One nit is the
following code in the test can be simplified as {{return
cluster.getNamesystem(0).getBlockManager().getPendingDeletionBlocksCount() ==
0}}.
{code}
if (cluster.getNamesystem(0).getBlockManager()
.getPendingDeletionBlocksCount() == 0) {
return true;
}
return false;
{code}
Besides, there is a typo in
{code}
168 // should stay in PENDING_THRESHOLD during trasitionToActive
{code}
+1 after addressing the comments.
> Namenode safemode not coming out during failover
> ------------------------------------------------
>
> Key: HDFS-10192
> URL: https://issues.apache.org/jira/browse/HDFS-10192
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Attachments: HDFS-10192-01.patch, HDFS-10192-02.patch
>
>
> Scenario:
> =======
> write some blocks
> wait till roll edits happen
> Stop SNN
> Delete some blocks in ANN, wait till the blocks are deleted in DN also.
> restart the SNN and Wait till block reports come from datanode to SNN
> Kill ANN then make SNN to Active.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
