[
https://issues.apache.org/jira/browse/HDFS-9735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229176#comment-15229176
]
Lei (Eddy) Xu commented on HDFS-9735:
-------------------------------------
Hi, [~anu]
Thanks a lot for updating the patch.
I have one question regarding {{-002.patch}}.
* In {{moveBlock()}}, from line 990 to line 997, {{finalizeReplicae(...)}} to
{{removeOldReplicas()}} are not atomic.
After {{finalizedReplica(...)}}, there is a short period of time, there are two
copies of the same replicas in the {{volumeMap}}, and both of them are visible
to others. It might be problematic that there is an append request or full
block report in between. Additionally, if there is any {{IOE}} thrown in
between, will the {{volumeMap}} become inconsistent?
> DiskBalancer : Refactor moveBlockAcrossStorage to be used by disk balancer
> --------------------------------------------------------------------------
>
> Key: HDFS-9735
> URL: https://issues.apache.org/jira/browse/HDFS-9735
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: balancer & mover
> Affects Versions: HDFS-1312
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Fix For: HDFS-1312
>
> Attachments: HDFS-9735-HDFS-1312.001.patch,
> HDFS-9735-HDFS-1312.002.patch
>
>
> Refactor moveBlockAcrossStorage so that code can be shared by both mover and
> diskbalancer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
