[
https://issues.apache.org/jira/browse/HDFS-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237871#comment-15237871
]
Jing Zhao commented on HDFS-10251:
----------------------------------
Thanks for working on this, Anu! The patch looks pretty good to me. One minor:
in the following code {{db.close}} may throw IOException. We may want to keep
the shutdown process even if one db.close fails. So maybe we can catch
IOException for each db#close here.
{code}
for (LevelDBStore db : handles) {
db.close();
}
{code}
One question I have is in {{OzoneContainer#stop}}, if one shutdown throws
IOException, do we want to continue the shutdown? And the further question is
whether shutdown API should throw IOException?
> Ozone: Shutdown cleanly
> -----------------------
>
> Key: HDFS-10251
> URL: https://issues.apache.org/jira/browse/HDFS-10251
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Fix For: HDFS-7240
>
> Attachments: HDFS-10251-HDFS-7240.001.patch
>
>
> Ozone containers needs to shutdown cleanly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
