[ https://issues.apache.org/jira/browse/HDFS-10208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238284#comment-15238284 ]
Sangjin Lee commented on HDFS-10208: ------------------------------------ Thanks for the clarification. I am then comfortable with those choices. It does appear the checkstyle violations are fixable. Could you please fix them? With that, it LGTM, but I'd like to give time for [~brahmareddy] to take a look at it too. > Addendum for HDFS-9579: to handle the case when client machine can't resolve > network path > ----------------------------------------------------------------------------------------- > > Key: HDFS-10208 > URL: https://issues.apache.org/jira/browse/HDFS-10208 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Ming Ma > Assignee: Ming Ma > Attachments: HDFS-10208-2.patch, HDFS-10208-3.patch, > HDFS-10208-4.patch, HDFS-10208.patch > > > If DFSClient runs on a machine that can't resolve network path, > {{DNSToSwitchMapping}} will return {{DEFAULT_RACK}}. In addition, if somehow > {{dnsToSwitchMapping.resolve}} returns null, that will cause exception when > it tries to create {{clientNode}}. In either case, there is no need to create > {{clientNode}} and we should treat its network distance with any datanode as > Integer.MAX_VALUE. > {noformat} > clientNode = new NodeBase(clientHostName, > dnsToSwitchMapping.resolve(nodes).get(0)); > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)