[ 
https://issues.apache.org/jira/browse/HDFS-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238891#comment-15238891
 ] 

Walter Su commented on HDFS-9825:
---------------------------------

The patch looks pretty good. Could you rebase it? And one question:
{code}
      for(int iteration = 0;; iteration++) {
        final Map<NameNodeConnector, Result> results = new LinkedHashMap<>();
        for(NameNodeConnector nnc : connectors) {
{code}
Does it need to retry the succeeded/failed namenodes in each iteration? Since 
One block pool may takes much longer than the others.

> Balancer should not terminate if only one of the namenodes has error
> --------------------------------------------------------------------
>
>                 Key: HDFS-9825
>                 URL: https://issues.apache.org/jira/browse/HDFS-9825
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: balancer & mover
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>         Attachments: h9825_20160217.patch, h9825_20160218.patch, 
> h9825_20160218b.patch
>
>
> Currently, the Balancer terminates if only one of the namenodes has error in 
> federation setting.  Instead, it should continue balancing the cluster with 
> the remaining namenodes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to