[ 
https://issues.apache.org/jira/browse/HDFS-9016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247248#comment-15247248
 ] 

Ming Ma commented on HDFS-9016:
-------------------------------

By default there is no format change.

||Scenarios||Prior to 2.8||2.8 with the patch||
|upgrade domain not enabled by default|current format|current format|
|config change to enable upgrade domain|undefined given upgrade domain feature 
wasn't available|additional upgrade domain string|

Here is another scenario. To enable upgrade domain upgrade, admins need to 
switch block placement policy. The switch might cause the fsck output to 
change, because the block placement policy defines part of fsck's error message 
from {{BlockPlacementPolicyDefault}}'s {{Block should be additionally 
replicated on 1 more rack(s) ...}} to 
{{BlockPlacementPolicyWithUpgradeDomain}}'s {{Block has 3 replicas. But only 
has 2 upgrade domains...}}

I can add another fsck flag for upgrade domain so that fsck won't return 
upgrade domain unless the flag is set, even when upgrade domain policy is used. 
But how do we handle the above scenario? It will break tools with the 
assumption about fsck's string content regardless of the configured block 
placement policy.

> Display upgrade domain information in fsck
> ------------------------------------------
>
>                 Key: HDFS-9016
>                 URL: https://issues.apache.org/jira/browse/HDFS-9016
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Ming Ma
>            Assignee: Ming Ma
>         Attachments: HDFS-9016.patch
>
>
> This will make it easy for people to use fsck to check block placement when 
> upgrade domain is enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to