[ 
https://issues.apache.org/jira/browse/HDFS-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15250520#comment-15250520
 ] 

Xiaobing Zhou commented on HDFS-10207:
--------------------------------------

Thanks [~xyao] for reviews. v005 addressed all your comments except 

bq. 2. Do we want to keep the unmodifieableList to avoid creating new list upon 
each NamenodeRpcServer#listReconfigurableProperties() call?

TreeSet style mutable RECONFIGURABLE_PROPERTIES is needed since
1. IPC_CLIENT_RPC_BACKOFF_ENABLE is initialized during NN instantiation, and 
then added to the collection.
2. to avoid duplicated entries as a result multiple NN instantiations.
3. some tests depend on order of reconfigurable properties in the collection.



> Support enable Hadoop IPC backoff without namenode restart
> ----------------------------------------------------------
>
>                 Key: HDFS-10207
>                 URL: https://issues.apache.org/jira/browse/HDFS-10207
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Xiaoyu Yao
>            Assignee: Xiaobing Zhou
>         Attachments: HDFS-10207-HDFS-9000.000.patch, 
> HDFS-10207-HDFS-9000.001.patch, HDFS-10207-HDFS-9000.002.patch, 
> HDFS-10207-HDFS-9000.003.patch, HDFS-10207-HDFS-9000.004.patch, 
> HDFS-10207-HDFS-9000.005.patch
>
>
> It will be useful to allow changing {{ipc.#port#.backoff.enable}} without a 
> namenode restart to protect namenode from being overloaded.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to