[jira] [Commented] (HDFS-10224) Implement asynchronous rename for DistributedFileSystem

[Tsz Wo Nicholas Sze (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HDFS-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15254463#comment-15254463
 ] 

Tsz Wo Nicholas Sze commented on HDFS-10224:
--------------------------------------------

Thanks for the new patch.  It looks good in general.  Some comments:
- In AsyncDistributedFileSystem, catch (Exception e)  and catch 
(UnresolvedLinkException e)  are not needed.
- In DistributedFileSystem, getAsyncDistributedFileSystem() should not create a 
new object each time.  It should just return the same object.  Also, let's 
annotate getAsyncDistributedFileSystem() as @Unstable.  I.e.
{code}
  private final AsyncDistributedFileSystem adfs = new 
AsyncDistributedFileSystem(this);

  /** @return an {@link AsyncDistributedFileSystem} object. */
  @Unstable
  public AsyncDistributedFileSystem getAsyncDistributedFileSystem() {
    return adfs;
  }
{code}


> Implement asynchronous rename for DistributedFileSystem
> -------------------------------------------------------
>
>                 Key: HDFS-10224
>                 URL: https://issues.apache.org/jira/browse/HDFS-10224
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: fs
>            Reporter: Xiaobing Zhou
>            Assignee: Xiaobing Zhou
>         Attachments: HDFS-10224-HDFS-9924.000.patch, 
> HDFS-10224-HDFS-9924.001.patch, HDFS-10224-HDFS-9924.002.patch, 
> HDFS-10224-HDFS-9924.003.patch, HDFS-10224-HDFS-9924.004.patch, 
> HDFS-10224-and-HADOOP-12909.000.patch
>
>
> This is proposed to implement an asynchronous DistributedFileSystem based on 
> AsyncFileSystem APIs in HADOOP-12910. In addition, rename is implemented in 
> this JIRA.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)