[
https://issues.apache.org/jira/browse/HDFS-9895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255304#comment-15255304
]
ASF GitHub Bot commented on HDFS-9895:
--------------------------------------
Github user arp7 commented on a diff in the pull request:
https://github.com/apache/hadoop/pull/92#discussion_r60831889
--- Diff:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
---
@@ -1239,9 +1236,8 @@ void startDataNode(Configuration conf,
synchronized (this) {
this.dataDirs = dataDirs;
}
- this.conf = conf;
- this.dnConf = new DNConf(conf);
- checkSecureConfig(dnConf, conf, resources);
+ this.dnConf = new DNConf(this);
--- End diff --
If we revert changes to DNConf we can just replace this with `this.dnConf =
new DNConf(getConf())`.
> Push up DataNode#conf to base class
> -----------------------------------
>
> Key: HDFS-9895
> URL: https://issues.apache.org/jira/browse/HDFS-9895
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode
> Reporter: Xiaobing Zhou
> Assignee: Xiaobing Zhou
> Attachments: HDFS-9895.000.patch, HDFS-9895.001.patch
>
>
> Since DataNode inherits ReconfigurableBase with Configured as base class
> where configuration is maintained, DataNode#conf should be removed for the
> purpose of brevity.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
