[
https://issues.apache.org/jira/browse/HDFS-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266677#comment-15266677
]
Andras Bokor commented on HDFS-9353:
------------------------------------
[~nijel] I think the comment is good. The "if not" belongs to the second part
of the sentence not the first one.
Anyway, it is open for misinterpretation. What do you think the comment is? How
about this?:
"Get the password file from the user's environment variable. If it is not set
get it from conf"
> Code and comment mismatch in JavaKeyStoreProvider
> ---------------------------------------------------
>
> Key: HDFS-9353
> URL: https://issues.apache.org/jira/browse/HDFS-9353
> Project: Hadoop HDFS
> Issue Type: Task
> Reporter: nijel
> Assignee: Nicole Pazmany
> Priority: Trivial
>
> In
> org.apache.hadoop.crypto.key.JavaKeyStoreProvider.JavaKeyStoreProvider(URI
> uri, Configuration conf) throws IOException
> The comment mentioned is
> {code}
> // Get the password file from the conf, if not present from the user's
> // environment var
> {code}
> But the code takes the value form ENV first
> I think this make sense since the user can pass the ENV for a particular run.
> My suggestion is to change the comment
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
