[
https://issues.apache.org/jira/browse/HDFS-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268954#comment-15268954
]
Colin Patrick McCabe commented on HDFS-10328:
---------------------------------------------
Thanks for the patch, [~xupener].
{code}
diff --git
a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/ClientNamenodeProtocol.proto
b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/ClientNamenodeProtocol.proto
index 7acb394..73db055 100644
---
a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/ClientNamenodeProtocol.proto
+++
b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/ClientNamenodeProtocol.proto
@@ -533,7 +533,8 @@ message CachePoolInfoProto {
optional string groupName = 3;
optional int32 mode = 4;
optional int64 limit = 5;
- optional int64 maxRelativeExpiry = 6;
+ optional uint32 defaultReplication = 6;
+ optional int64 maxRelativeExpiry = 7;
}
{code}
Please be careful not to remove or change fields that already exist. In this
case, you have moved maxRelativeExpiry from field 6 to field 7, which is an
incompatible change. Instead, you should simply add your new field to the end.
I suggest using something like this:
{code}
+ optional uint32 defaultReplication = 6 [default=1];
{code}
To avoid having to programmatically add a default of 1 in so many places.
> Add per-cache-pool default replication num configuration
> --------------------------------------------------------
>
> Key: HDFS-10328
> URL: https://issues.apache.org/jira/browse/HDFS-10328
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: caching
> Reporter: xupeng
> Assignee: xupeng
> Priority: Minor
> Fix For: 2.3.0
>
> Attachments: HDFS-10328.001.patch, HDFS-10328.002.patch
>
>
> For now, hdfs cacheadmin can not set a default replication num for cached
> directive in the same cachepool. Each cache directive added in the same cache
> pool should set their own replication num individually.
> Consider this situation, we add daily hive table into cache pool "hive" .Each
> time i should set the same replication num for every table directive in the
> same cache pool.
> I think we should enable setting a default replication num for a cachepool
> that every cache directive in the pool can inherit replication configuration
> from the pool. Also cache directive can override replication configuration
> explicitly by calling "add & modify directive -replication" command from
> cli.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
