[
https://issues.apache.org/jira/browse/HDFS-10337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15272829#comment-15272829
]
Akira AJISAKA commented on HDFS-10337:
--------------------------------------
Thanks [~linyiqun] for updating the patch. Three comments:
* Would you fix the findbugs warning?
{code}
count == null ? 0 : count));
{code}
According to https://sourceforge.net/p/findbugs/bugs/1184/, if count is not
null, count is unboxed and then immediately reboxed. We can fix it by
{code}
count == null ? Long.valueOf(0L) : count));
{code}
* Would you fix the checkstyle warning?
* Would you add a regression test for this issue?
> OfflineEditsViewer stats option should print 0 instead of null for the count
> of operations
> ------------------------------------------------------------------------------------------
>
> Key: HDFS-10337
> URL: https://issues.apache.org/jira/browse/HDFS-10337
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.7.2
> Reporter: Akira AJISAKA
> Assignee: Lin Yiqun
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-10337.001.patch, HDFS-10337.002.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
