[ 
https://issues.apache.org/jira/browse/HDFS-10346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15277031#comment-15277031
 ] 

Tsz Wo Nicholas Sze commented on HDFS-10346:
--------------------------------------------

Thanks Xiaobing!  Some comment ont he patch.
- In AsyncDistributedFileSystem,
-* Need to call fixRelativePart.
-* javadoc should describe return value.
- testPermissionChecking should first create all files/directories 
synchronously, and then call setPermission/setOwner asynchronously in a 
separated loop.
- Indeed, testAggressiveConcurrentAsyncAPI is a better test.  Why don't we just 
keep it and remove testPermissionChecking?
- I suggest to add one more test to mix up rename/setPermission/setOwner 
together.


> Implement asynchronous setPermission/setOwner for DistributedFileSystem
> -----------------------------------------------------------------------
>
>                 Key: HDFS-10346
>                 URL: https://issues.apache.org/jira/browse/HDFS-10346
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs, hdfs-client
>            Reporter: Xiaobing Zhou
>            Assignee: Xiaobing Zhou
>         Attachments: HDFS-10346-HDFS-9924.000.patch, 
> HDFS-10346-HDFS-9924.001.patch, HDFS-10346-HDFS-9924.003.patch
>
>
> This is proposed to implement an asynchronous setPermission and setOwner.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to